Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fix some compile time warnings with .NET 8/9 #20

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

adrum
Copy link
Contributor

@adrum adrum commented Dec 14, 2024

I was getting the following:

/projects/InertiaCore/InertiaCore/Response.cs(66,9): warning ASP0019: Use IHeaderDictionary.Append or the indexer to append or set headers. IDictionary.Add will throw an ArgumentException when attempting to add a duplicate key. (https://aka.ms/aspnet/analyzers) /projects/InertiaCore/InertiaCore/InertiaCore.csproj::TargetFramework=net8.0]
/projects/InertiaCore/InertiaCore/Response.cs(67,9): warning ASP0019: Use IHeaderDictionary.Append or the indexer to append or set headers. IDictionary.Add will throw an ArgumentException when attempting to add a duplicate key. (https://aka.ms/aspnet/analyzers) /projects/InertiaCore/InertiaCore/InertiaCore.csproj::TargetFramework=net8.0]
/projects/InertiaCore/InertiaCore/Utils/InertiaActionFilter.cs(35,9): warning ASP0019: Use IHeaderDictionary.Append or the indexer to append or set headers. IDictionary.Add will throw an ArgumentException when attempting to add a duplicate key. (https://aka.ms/aspnet/analyzers) /projects/InertiaCore/InertiaCore/InertiaCore.csproj::TargetFramework=net8.0]
/projects/InertiaCore/InertiaCore/Extensions/Configure.cs(72,9): warning ASP0019: Use IHeaderDictionary.Append or the indexer to append or set headers. IDictionary.Add will throw an ArgumentException when attempting to add a duplicate key. (https://aka.ms/aspnet/analyzers) /projects/InertiaCore/InertiaCore/InertiaCore.csproj::TargetFramework=net8.0]
/projects/InertiaCore/InertiaCore/Utils/LocationResult.cs(17,13): warning ASP0019: Use IHeaderDictionary.Append or the indexer to append or set headers. IDictionary.Add will throw an ArgumentException when attempting to add a duplicate key. (https://aka.ms/aspnet/analyzers) /projects/InertiaCore/InertiaCore/InertiaCore.csproj::TargetFramework=net8.0]

If/when accepted, it could also be merged into main.

@adrum adrum marked this pull request as draft December 15, 2024 03:31
@adrum adrum changed the title [1.x] Fix some compile time warnings [1.x] Fix some compile time warnings with .NET 8/9 Dec 21, 2024
@adrum adrum marked this pull request as ready for review December 21, 2024 04:58
@adrum adrum mentioned this pull request Dec 21, 2024
@kapi2289 kapi2289 merged commit e5644b4 into kapi2289:v1 Dec 30, 2024
@adrum adrum deleted the fix/warnings branch March 2, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants