Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not following RFC6763 section 6.3 #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgirard1mtx
Copy link

RFC6763 section 6.3:
Specifies that each key/value pair is encoded as its own constituent string. So each bytes length + string is a key value pair.

I tested this with an IPMX registry device.

Before the fix the Attribute where mangled (a single key/pair).

After the proposed fix each Key Value pairs matches the output from standard tools like dig.

… as its own constitent string (each len + strings is a key/value pair).
@mgirard1mtx
Copy link
Author

Here is an example dig answer to a TXT request:

;; ANSWER SECTION:
deviceNameRemoved._nmos-register._tcp.matrox.com. 0 IN TXT "api_ver=v1.0,v1.1,v1.2,v1.3" "api_proto=http" "pri=5" "api_auth=false"

In this case the TXT RData contains 4 strings which are each key value pairs:

  • "api_ver=v1.0,v1.1,v1.2,v1.3"
  • "api_proto=http"
  • "pri=5"
  • "api_auth=false"

@mgirard1mtx
Copy link
Author

@kapetan do I need to do something for that p.r. ?

The txt have a slight bug where multi Txt record are not handle properly (we treat the list of key value as a single key value pair).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant