Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix: make sure names are kubernetes compatible names #725

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

Delawen
Copy link
Collaborator

@Delawen Delawen commented Jun 28, 2023

Fixes #723

@Delawen Delawen requested a review from a team June 28, 2023 07:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.5% 2.5% Duplication

@Delawen Delawen enabled auto-merge (rebase) June 28, 2023 09:19
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #725 (53c31f9) into main (411a91e) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #725      +/-   ##
============================================
- Coverage     79.91%   79.86%   -0.06%     
+ Complexity      160      159       -1     
============================================
  Files            53       53              
  Lines          2788     2791       +3     
  Branches        457      457              
============================================
+ Hits           2228     2229       +1     
- Misses          374      375       +1     
- Partials        186      187       +1     
Impacted Files Coverage Δ
.../backend/api/resource/v2/IntegrationsResource.java 80.88% <100.00%> (+0.88%) ⬆️

... and 1 file with indirect coverage changes

@Delawen
Copy link
Collaborator Author

Delawen commented Jun 28, 2023

Thank you @syednabilashraf for checking!

@Delawen Delawen merged commit f9c6401 into kaoto-archive:main Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Invalid /metadata/name format for generated ids of Integration
3 participants