Initial implementation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[wip] add type-safety on various indices [wip] editor widget constrain editing widget to table body improve active ui rendering improve active row edit size handling improve window rect layout change selection to use visual coords Extract rendering logics to separate class [wip] command system extract body display method implement visual repr of temporary selection [wip] hotkey handling change cursor state-machine based verify undo/redo/hotkeys [wip] changing to cell based edition - User should not care about which column should be editted - Columns may change at any time. - Therefore, cell based edition is appropriate. [wip] implement basic edition fix remained garbage on focus movement add dirty flag field on sheet fix cci_selection rendering implement column reordering fix column pos calculation edit table column rendering config verify filtering make more tolerant to viewer hash - Now selection is transient. implement sorting improve sorting
kang-sw
force-pushed
the
feature/1-initial
branch
from
be84cd4 to
39bc829
Compare
rename instant command variants prefixed with cc redefine UiActions remove unnecessary unsafe logic implement context menu popup fix interactive validation change sort order icon improve selection stability remove redundant local variable improve context menu rendering implement `Insert/RemoveRow` command implement basic commands verify row duplication/removal improve visual stability when sorted Tidy code extract copy/cut event filtering remove `hash` requirements from viewer improve viewer state change detection implement multiselect tidy dup/del behavior add several interfaces implement cell duplication implement internal clipboard past fix editor position when sorted implement SetCell command remove `Clone` requirement from `R` implement paste verify drop reaction rename `sheet` to `table
kang-sw
force-pushed
the
feature/1-initial
branch
from
cc89e7b to
1d5d580
Compare
rename trait methods change viewer return list of hotkeys implement shortcut display change default insertion policy [wip] web publish implement cell based editor add hotkey display on demo implement keyboard navigation
kang-sw
force-pushed
the
feature/1-initial
branch
from
21d48e8 to
2228163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
Issue: Table and inner widget interactivity
Seems
eguiPR emilk/egui#2244 blocks interaction of underlying table column widgets when table interaction is enabled. To address this issue, currently separated window is created upon table area to activate 'editor view', which is not desirable.This seems comes from(not bug)
egui_extras::Layout::addmethod that is invoked byTableRow::col._::Layout::addcallsself.cell(.., add_cell_contents)before calling intoself.ui.allocate_rectfor retrieving cell interaction, which simply covers interaction area of user-requested ui fromadd_cell_contents.Prior to egui 0.20(from mentioned PR), it was just okay since there were no input priority between widgets within same area. However, afther the PR, it seems widget interaction now have kinda 'latest first' priority, which prevents passing-through user interactions.
However, I don't know why the egui web demo page works with this well; perhaps its version is less than 0.20? Otherwise, it'll be my setup issue? Should be tested with wasm32 build either...