Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apollo-angular): Adds flushData method to TestingOperation #1474

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

fetis
Copy link
Contributor

@fetis fetis commented Mar 6, 2020

closes #1469
plus, some refactoring for tests

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Try to include the Pull Request inside of CHANGELOG.md

I'm not sure about changelogs. Shall I do it manually?

@apollo-cla
Copy link

@fetis: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@fetis fetis changed the title feat(apollo-angular): Adds flustData method to TestingOperation feat(apollo-angular): Adds flushData method to TestingOperation Mar 6, 2020
@fetis
Copy link
Contributor Author

fetis commented Mar 17, 2020

any feedback on it?

@fetis
Copy link
Contributor Author

fetis commented May 14, 2020

@kamilkisiela could u plz take a look?

@kamilkisiela kamilkisiela merged commit 72cdeb0 into kamilkisiela:master Aug 4, 2020
@fetis fetis deleted the flush_data branch August 5, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flushData method for testing
3 participants