Patches from the RPM install #871
Conversation
…s, this will not work and only clutter the log with errors that are not truly errors.
…st before attempting to remove to avoid errors in the cronlog.
also, unless we change hard coded with path "/usr/sbin/httpd" no point for the @APACHE_SERVICE@ place holder as in other distributions, for instance Debian/Ubuntu, the daemon's name is 'apache2' and so is its init script under /usr/sbin.
…has been requested. Set SCRIPTDIR.
| @@ -1,7 +1,7 @@ | |||
| check process apache | |||
| with pidfile "/var/run/httpd/httpd.pid" | |||
| start program = "service @APACHE_SERVICE@ start" with timeout 60 seconds | |||
| stop program = "service @APACHE_SERVICE@ stop" | |||
| start program = "/sbin/service httpd start" with timeout 60 seconds | |||
There was a problem hiding this comment.
Why did you change it?
We should support Ubuntu as well.
There was a problem hiding this comment.
Unless we replace with path "/usr/sbin/httpd" as well, it does
not help..
So if we want to support other distros, we need to add one more holder.
Thanks,
May the source be with you,
Jess Portnoy
On Mon, 17 Feb 2014, Tan-Tan wrote:
In configurations/monit/monit.d/httpd.template.rc:
@@ -1,7 +1,7 @@
check process apache
with pidfile "/var/run/httpd/httpd.pid"
start program = "service @APACHE_SERVICE@ start" with timeout 60 secondsstop program = "service @APACHE_SERVICE@ stop"start program = "/sbin/service httpd start" with timeout 60 secondsWhy did you change it?
We should support Ubuntu as well.—
Reply to this email directly or view it on
GitHub.[5270205__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwODE5NDEzNSwiZGF0YSI6eyJpZCI6MjU4MzgwNjF9fQ==--03da50802521317c35c59e3d1bb6d884d95a7c7f.gif]
There was a problem hiding this comment.
In Ubuntu the @APACHE_SERVICE@ == apache2 should work.
From: Jess Portnoy [mailto:[email protected]]
Sent: Monday, February 17, 2014 9:05 PM
To: kaltura/server
Cc: Jonathan Kanarek
Subject: Re: [server] Patches from the RPM install (#871)
In configurations/monit/monit.d/httpd.template.rc:
@@ -1,7 +1,7 @@
check process apache with pidfile "/var/run/httpd/httpd.pid"
start program = "service @APACHE_SERVICE@ start" with timeout 60 secondsstop program = "service @APACHE_SERVICE@ stop"start program = "/sbin/service httpd start" with timeout 60 secondsUnless we replace with path "/usr/sbin/httpd" as well, it does not help.. So if we want to support other distros, we need to add one more holder. Thanks, May the source be with you, Jess Portnoy
…
On Mon, 17 Feb 2014, Tan-Tan wrote: In configurations/monit/monit.d/httpd.template.rc: > @@ -1,7 +1,7 @@ > check process apache > with pidfile "/var/run/httpd/httpd.pid" > - start program = "service @APACHE_SERVICE@ start" with timeout 60 seconds > - stop program = "service @APACHE_SERVICE@ stop" > + start program = "/sbin/service httpd start" with timeout 60 seconds Why did you change it? We should support Ubuntu as well. — Reply to this email directly or view it on GitHub.[5270205__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwODE5NDEzNSwiZGF0YSI6eyJpZCI6MjU4MzgwNjF9fQ==--03da50802521317c35c59e3d1bb6d884d95a7c7f.gif]
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/871/files#r9801372.
| with pidfile "/var/run/httpd/httpd.pid" | ||
| start program = "service @APACHE_SERVICE@ start" with timeout 60 seconds | ||
| stop program = "service @APACHE_SERVICE@ stop" | ||
| with pidfile "@PID_FILE@" |
There was a problem hiding this comment.
Please call it @APACHE_PID_PATH@ and add it to installer repo in installer/AppConfig.class.php.
There was a problem hiding this comment.
done:)
Also submitted a pull for the installer repo.
Thanks,
May the source be with you,
Jess Portnoy
On Tue, 18 Feb 2014, Tan-Tan wrote:
In configurations/monit/monit.d/httpd.template.rc:
@@ -1,7 +1,7 @@
check process apache
with pidfile "/var/run/httpd/httpd.pid"start program = "service @APACHE_SERVICE@ start" with timeout 60 secondsstop program = "service @APACHE_SERVICE@ stop"with pidfile "@PID_FILE@"Please call it @APACHE_PID_PATH@ and add it to installer repo in installer/AppConfig.class.php.
—
Reply to this email directly or view it on
GitHub.[2227038__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwODI0Nzc0NSwiZGF0YSI6eyJpZCI6MjU4MzgwNjF9fQ==--5ef760579884f7abc46a9c2e33176256a5eec51c.gif]
|
Broked them into smaller pulls. |
See commit log.