supporting banSeekManager plugin from Editor #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Live Pull Request Urls
|
1 similar comment
Live Pull Request Urls
|
eitanavgil
suggested changes
Jan 30, 2018
modules/Quiz/resources/IVQModule.js
Outdated
| @@ -53,11 +53,28 @@ | |||
| } | |||
| else { | |||
| $.quizParams = data[1]; | |||
| var banSeekTrigger = false; | |||
| var dataForBanSeek = { | |||
There was a problem hiding this comment.
@MaksymKorniiov
To me it looks that there is a redundant variable here. Do we need banSeekTrigger if we are also saving the same value in dataForBanSeek?
modules/Quiz/resources/IVQModule.js
Outdated
|
|
||
| if (e.key == "banSeek" && e.value) { | ||
| banSeekTrigger = true; | ||
| dataForBanSeek.status = true; |
There was a problem hiding this comment.
@MaksymKorniiov - I see that a few lines below there is a e.value.toLowerCase()
Do you see a reason for use/not use the same protection here?
eitanavgil
suggested changes
Feb 25, 2018
1. fix from PR comments 2. rename alertText to noSeekAlertText
Updated pull request 3703: 29e40f1
|
eitanavgil
approved these changes
Feb 27, 2018
eitanavgil
added a commit
that referenced
this pull request
Mar 28, 2018
* 1. add feature to getting CP type 2. add new property to CP (partnerData) * 1. change partnerData to questionType 2. rename questions type * 1. Add const QuestionsType * FEV-138 (#3729) [IVQ-Player] show answers should still show questions. * FEV-132 (#3730) [IVQ-Player] New Q type #2: True/False * 1. Add const QuestionsType (#3728) * ivq-enhancements: add opacity to reflection point on last screen * ivq-enhancements: fix css. add new imgs * FEV-166: (#3736) * FEV-166: Support links in questions fields * renaming function and change comments * KMS-17072-information-screen-after-submit: (#3744) IVQ: No information and elements when question icon clicked on Submit screen * KMS-16785-remove-welcome-page: (#3742) * KMS-16785-remove-welcome-page: [IVQ-Editor] new option to remove welcome page * KMS-16785-remove-welcome-page: space fix * FEV-130 - IVQ, Skip Back/Next (#3651) * FEV-140 [IVQ-Player] local issue - continue used for 2 places Without UI * FEV-130 1. add imgs 2. fix position * FEV-130 - IVQ, Skip Back/Next 1: add comments 2: change logic * supporting banSeekManager plugin from Editor (#3703) * supporting banSeekManager plugin from Editor * banSeek_editorSupport 1. fix from PR comments 2. rename alertText to noSeekAlertText * FEV-131-auto-submit-rp: (#3750) 1. when reached reflection point - auto submit it * bump version * FEV-172-align-mid-RP-text: (#3756) * FEV-172-align-mid-RP-text: 1. vertical-align for RP text * FEV-172-align-mid-RP-text: 1. fix width * Fev 150 block portrait mode (#3761) * FEV-150 - quiz handle portrait UX * FEV-150_block_portrait_mode: 1. show overlay with portrait warning on mobile + vertical screens * FEV-150_block_portrait_mode: 1. add event only if has mobile class 2. change function name * FEV-171-design-changes (#3755) * FEV-171-design-changes 1. change quiz-screen background 2. change font color 3. add icon for submit and review buttons * fix backgrounds * FEV-171-fix-designs: (#3763) 1. remove hover effect 2. wrong answers - with border * Update DefaultSettings.php * bump version to IVQ * KMS-17284-submit-and-review-buttons-text-size: (#3779) 1. fix font-size and display of review and submit buttons * KMS-17301-true-false-inline-position: (#3778) fix margin between true/false answers * FEV-173-skip-for-now-overlay: (#3777) fix bottom position of footer and margin between answers * revert version back to main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use banSeekManager if add status for it in Editor