wip: refactor common.environment.render [pack]

kalisio · Feb 2, 2022 · e10a19a · e10a19a
1 parent 971d964
commit e10a19a
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 29 deletions.
diff --git a/charts/common/templates/_.environment.tpl b/charts/common/templates/_.environment.tpl
@@ -1,27 +1,9 @@
 {{/*
 Renders an object that contains a list of key/value properties that can be transformed into environement variables
 Usage:
-{{ include "common.environment.render" . }}
+{{ include "common.environment.render" (dict "env" .Values.path.to.the.env "context" $) }}
 */}}
 {{- define "common.environment.render" -}}
-{{- $defaultSecret := include "common.names.secret" . }}
-{{- range $key, $value := .Values.env }}
-- name: {{ $key | snakecase | upper}}
-  {{- if kindIs "map" $value }}
-  valueFrom:
-    secretKeyRef:
-      name: {{ $value.secret | default $defaultSecret }}
-      key: {{ $value.key | default (kebabcase $key) }}
-  {{- else }}
-  value: {{ include "common.tplvalues.render" (dict "value" $value "context" $) | quote }}
-  {{- end }}
-{{- end }}
-{{- end -}}
-
-
-{{/*
-*/}}
-{{- define "common.environment.renderImpl" -}}
 {{- $defaultSecret := include "common.names.secret" .context }}
 {{- range $key, $value := .env }}
 - name: {{ $key | snakecase | upper}}

diff --git a/charts/common/templates/_envsubstConfig.tpl b/charts/common/templates/_envsubstConfig.tpl
@@ -1,7 +1,7 @@
 {{/*
 Renders an object that contains a list of key/value properties that can be transformed into environement variables
 Usage:
-{{ include "common.environment.render" . }}
+{{ include "common.envsubstConfig.renderInitContainer" . }}
 */}}
 {{- define "common.envsubstConfig.renderInitContainer" -}}
 - name: envsubst-config
@@ -28,7 +28,7 @@ Usage:
     - '{}'
     - ';'
   env:
-    {{- include "common.environment.renderImpl" (dict "env" .args.env "context" .context) | indent 4 }}
+    {{- include "common.environment.render" (dict "env" .args.env "context" .context) | indent 4 }}
   volumeMounts:
     - mountPath: /templated
       name: envsubst-template-config
@@ -40,7 +40,7 @@ Usage:
 {{/*
 Renders an object that contains a list of key/value properties that can be transformed into environement variables
 Usage:
-{{ include "common.environment.render" . }}
+{{ include "common.envsubstConfig.renderVolume" . }}
 */}}
 {{- define "common.envsubstConfig.renderVolume" -}}
 - name: envsubst-template-config

diff --git a/charts/common/templates/_kdk-deployment.yaml b/charts/common/templates/_kdk-deployment.yaml
@@ -48,7 +48,7 @@ spec:
                   name: {{ .Values.distribution.redisUrl.secret | default (include "common.names.secret" .) }}
                   key: {{ .Values.distribution.redisUrl.key | default "redis-url" }}
             {{- end }}
-            {{- include "common.environment.render" . | indent 12 }}
+            {{- include "common.environment.render" (dict "env" .Values.env "context" $) | indent 12 }}
           ports:
             - name: {{ include "common.names.name" . }}
               containerPort: 8081

diff --git a/charts/common/templates/_krawler-cronjob.yaml b/charts/common/templates/_krawler-cronjob.yaml
@@ -29,7 +29,7 @@ spec:
               env:          
                 - name: CRON
                   value: "" 
-              {{- include "common.environment.render" . | indent 16 }}
+              {{- include "common.environment.render" (dict "env" .Values.env "context" $) | indent 16 }}
               {{- if .Values.volumeMounts }}
               volumeMounts:
                 {{- include "common.tplvalues.render" ( dict "value" .Values.volumeMounts "context" $ ) | nindent 14 }}

diff --git a/charts/express-gateway/templates/deployment.yaml b/charts/express-gateway/templates/deployment.yaml
@@ -36,7 +36,7 @@ spec:
             - name: HTTP_PROXY
             - name: HTTPS_PROXY
             - name: NO_PROXY
-            {{- include "common.environment.render" . | indent 12 }}
+            {{- include "common.environment.render" (dict "env" .Values.env "context" $) | indent 12 }}
           ports:
             - name: {{ include "common.names.name" . }}
               containerPort: 8080

diff --git a/charts/k2/templates/deployment.yaml b/charts/k2/templates/deployment.yaml
@@ -26,7 +26,7 @@ spec:
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           env:
-            {{- include "common.environment.render" . | indent 12 }}
+            {{- include "common.environment.render" (dict "env" .Values.env "context" $) | indent 12 }}
           ports:
             - name: {{ include "common.names.name" . }}
               containerPort: 8080

diff --git a/charts/kapture/templates/deployment.yaml b/charts/kapture/templates/deployment.yaml
@@ -26,7 +26,7 @@ spec:
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           env:
-            {{- include "common.environment.render" . | indent 12 }}
+            {{- include "common.environment.render" (dict "env" .Values.env "context" $) | indent 12 }}
           ports:
             - name: {{ include "common.names.name" . }}
               containerPort: 3000

diff --git a/charts/mongo-express/templates/deployment.yaml b/charts/mongo-express/templates/deployment.yaml
@@ -26,7 +26,7 @@ spec:
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           env:
-            {{- include "common.environment.render" . | indent 12 }}
+            {{- include "common.environment.render" (dict "env" .Values.env "context" $) | indent 12 }}
           ports:
             - name: {{ include "common.names.name" . }}
               containerPort: 8081           

diff --git a/charts/redis-commander/templates/deployment.yaml b/charts/redis-commander/templates/deployment.yaml
@@ -26,7 +26,7 @@ spec:
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           env:
-            {{- include "common.environment.render" . | indent 12 }}
+            {{- include "common.environment.render" (dict "env" .Values.env "context" $) | indent 12 }}
           ports:
             - name: {{ include "common.names.name" . }}
               containerPort: 8081