when installing sequitur and mmseg, look for lib64 as well #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayc11
reviewed
Jun 10, 2017
tools/extras/install_mmseg.sh
Outdated
|
|
||
| echo "export PYTHONPATH=\$PYTHONPATH:$wd/mmseg-1.3.0/lib/python${pyver}/site-packages" | ||
| site_packages_dir=$(cd ./mmseg-1.3.0; find $libdir -name "site-packages" -type d | head -n1) |
There was a problem hiding this comment.
Should be
site_packages_dir=$(cd ./mmseg-1.3.0; find $lib_dir -name "site-packages" -type d | head -n1)
akshayc11
reviewed
Jun 10, 2017
tools/extras/install_mmseg.sh
Outdated
| ## the location of the mmseg.py file but using find seems more reliable | ||
| mmseg_file_lib=$(find ./mmseg-1.3.0/lib/ -type f -name mmseg.py | head -n 1) | ||
| mmseg_file_lib64=$(find ./mmseg-1.3.0/lib64/ -type f -name mmseg.py | head -n 1) | ||
| if [ -f $mmseg_file_lib ]; then |
There was a problem hiding this comment.
For some reason this was failing in my code. I tried the following:
if [ ! -z ${mmseg_file_lib+x} ]; then
lib_dir=./lib/
elif [ ! -z ${mmseg_file_lib64+x} ]; then
lib_dir=./lib64/
else
...
Based on https://stackoverflow.com/questions/3601515/how-to-check-if-a-variable-is-set-in-bash
|
There was 1 typo, and 1 correction (using -z instead of -f) in the install_mmseg.sh. Please refer to the inline comments for more details.. Otherwise, worked in my machine. Looks good to me. |
jtrmal
force-pushed
the
mmseg_sequitur_fix
branch
from
b9e035e to
33065c3
Compare
|
Thanks for testing it. Now those issues should be addressed. |
|
I did... Sequitur passed. |
|
ok to merge, by me. |
|
Great. Thanks a lot.
@danpovey I think ready to merge
Y.
…On Jun 12, 2017 8:34 AM, "Akshay Chandrashekaran" ***@***.***> wrote:
I did... Sequitur passed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1677 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKisX3pmnXVaJmvny7ZHDBux-l7nnrPGks5sDNwBgaJpZM4N2EVB>
.
|
kronos-cm
added a commit
to kronos-cm/kaldi
that referenced
this pull request
Jun 15, 2017
* 'master' of https://github.com/kaldi-asr/kaldi: (140 commits) [egs] Fix failure in multilingual BABEL recipe (regenerate cmvn.scp) (kaldi-asr#1686) [src,scripts,egs] Backstitch code+scripts, and one experiment, will add more later. (kaldi-asr#1605) [egs] CNN+TDNN+LSTM experiments on AMI (kaldi-asr#1685) [egs,scripts,src] Tune image recognition examples; minor small changes. (kaldi-asr#1682) [src] Fix bug in looped computation (kaldi-asr#1673) [build] when installing sequitur and mmseg, look for lib64 as well (thanks: @akshayc11) (kaldi-asr#1677) [src] fix to gst-plugin/Makefile (remove -lkaldi-thread) (kaldi-asr#1680) [src] Cosmetic fixes to usage messages [egs] Fix to some --proportional-shrink related example scripts (kaldi-asr#1674) [build] Fix small bug in configure [scripts] Fix small bug in utils/gen_topo.pl. [scripts] Add python script to convert nnet2 to nnet3 models (kaldi-asr#1611) [doc] Fix typo (kaldi-asr#1669) [src] nnet3: fix small bug in checking code. Thanks: @Maddin2000. [src] Add #include missing from previous commit [src] Fix bug in online2-nnet3 decoding RE dropout+batch-norm (thanks: Wonkyum Lee) [scripts] make errors getting report non-fatal (thx: Miguel Jette); add comment RE dropout proportion [src,scripts] Use ConstFst or decoding (half the memory; slightly faster). (kaldi-asr#1661) [src] keyword search tools: fix Minimize() call, necessary due to OpenFst upgrade (kaldi-asr#1663) [scripts] do not fail if the ivector extractor belongs to different user (kaldi-asr#1662) ...
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be addressing #1672