Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Target Modules Env Variable and ETCD Cleanup #489

Merged
merged 14 commits into from
Jul 2, 2024
Merged

feat: Add Target Modules Env Variable and ETCD Cleanup #489

merged 14 commits into from
Jul 2, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Jun 28, 2024 •
edited
Loading

Reason for Change:

  • Add env variable for custom target_modules

Additional Minor change:

  • Ensure Kind ETCD directory cleanup between runs

@ishaansehgal99 ishaansehgal99 changed the title feat: Image updates feat: Target Modules Env Variable Jun 28, 2024
@ishaansehgal99 ishaansehgal99 changed the title feat: Target Modules Env Variable feat: Add Target Modules Env Variable Jun 28, 2024
@ishaansehgal99 ishaansehgal99 merged commit 001df06 into main Jul 2, 2024
8 of 12 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/image-update branch July 2, 2024 03:48
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Jul 12, 2024
@ishaansehgal99 @smritidahal653
feat: Add Target Modules Env Variable (kaito-project#489)
c913bb9 
**Reason for Change**:
- Add env variable for custom target_modules

---------

Signed-off-by: Ishaan Sehgal <[email protected]>
@ishaansehgal99 ishaansehgal99 changed the title feat: Add Target Modules Env Variable feat: Add Target Modules Env Variable and ETCD Cleanup Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishaansehgal99 @Fei-Guo