Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Util funcs, updating func names, logs, configs and ensure service requirement #485

Merged
merged 10 commits into from
Jun 28, 2024
Merged

feat: Add Util funcs, updating func names, logs, configs and ensure service requirement #485

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
16cf236
fix: inference workspace
ishaansehgal99 Jun 27, 2024
5376c03
fix: allow private path for public presets
ishaansehgal99 Jun 27, 2024
a6ab5b1
feat: add download logs
ishaansehgal99 Jun 27, 2024
20b3e28
feat: deepspeed causes breaking change include in future release
ishaansehgal99 Jun 27, 2024
1687eac
feat: Add generate random string
ishaansehgal99 Jun 27, 2024
c741bd2
feat: add util functions
ishaansehgal99 Jun 27, 2024
dd5d070
fix: ensure service not required for tunin
ishaansehgal99 Jun 27, 2024
d1233fd
fix: inference workspace
ishaansehgal99 Jun 27, 2024
e2ac6cf
fix: url data source
ishaansehgal99 Jun 27, 2024
40c32d1
fix: simplify check
ishaansehgal99 Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: simplify check
  • Loading branch information
@ishaansehgal99
ishaansehgal99 committed Jun 27, 2024
commit 40c32d101325aafefdc99bc8e7f159e41194227b
4 changes: 2 additions & 2 deletions pkg/inference/preset-inferences.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ func updateTorchParamsForDistributedInference(ctx context.Context, kubeClient cl

func GetInferenceImageInfo(ctx context.Context, workspaceObj *kaitov1alpha1.Workspace, presetObj *model.PresetParam) (string, []corev1.LocalObjectReference) {
imagePullSecretRefs := []corev1.LocalObjectReference{}
if presetObj.ImageAccessMode == string(kaitov1alpha1.ModelImageAccessModePrivate) ||
string(workspaceObj.Inference.Preset.AccessMode) == string(kaitov1alpha1.ModelImageAccessModePrivate) {
// Check if the workspace preset's access mode is private
if string(workspaceObj.Inference.Preset.AccessMode) == string(kaitov1alpha1.ModelImageAccessModePrivate) {
imageName := workspaceObj.Inference.Preset.PresetOptions.Image
for _, secretName := range workspaceObj.Inference.Preset.PresetOptions.ImagePullSecrets {
imagePullSecretRefs = append(imagePullSecretRefs, corev1.LocalObjectReference{Name: secretName})
Expand Down
4 changes: 2 additions & 2 deletions pkg/tuning/preset-tuning.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ func getInstanceGPUCount(sku string) int {

func GetTuningImageInfo(ctx context.Context, workspaceObj *kaitov1alpha1.Workspace, presetObj *model.PresetParam) (string, []corev1.LocalObjectReference) {
imagePullSecretRefs := []corev1.LocalObjectReference{}
if presetObj.ImageAccessMode == string(kaitov1alpha1.ModelImageAccessModePrivate) ||
string(workspaceObj.Tuning.Preset.AccessMode) == string(kaitov1alpha1.ModelImageAccessModePrivate) {
// Check if the workspace preset's access mode is private
if string(workspaceObj.Tuning.Preset.AccessMode) == string(kaitov1alpha1.ModelImageAccessModePrivate) {
imageName := workspaceObj.Tuning.Preset.PresetOptions.Image
for _, secretName := range workspaceObj.Tuning.Preset.PresetOptions.ImagePullSecrets {
imagePullSecretRefs = append(imagePullSecretRefs, corev1.LocalObjectReference{Name: secretName})
Expand Down
Loading