Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add E2E Tests for Phi-3 and Tuning #476

Merged
merged 64 commits into from
Jul 8, 2024
Merged

feat: Add E2E Tests for Phi-3 and Tuning #476

merged 64 commits into from
Jul 8, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Jun 18, 2024 •
edited
Loading

Reason for Change:

  1. Add E2E tests for Phi-3 and Tuning
  2. Uses temporary ACR for uploading e2e results
  3. Allows a public preset to be used in private accessmode with private ACR path
  4. Adds Validation check for count > 1 for Tuning

@ishaansehgal99
Update Makefile
8c48497 
Signed-off-by: Ishaan Sehgal <[email protected]>
bangqipropel
bangqipropel approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@bangqipropel bangqipropel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

presets/models/falcon/model.go Show resolved Hide resolved
@ishaansehgal99 ishaansehgal99 merged commit e5e61a7 into main Jul 8, 2024
5 of 6 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/e2e-tuning branch July 8, 2024 02:32
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Jul 12, 2024
@ishaansehgal99 @smritidahal653
feat: Add E2E Tests for Phi-3 and Tuning (kaito-project#476)
08750f6 
**Reason for Change**:
1. Add E2E tests for Phi-3 and Tuning
2. Uses temporary ACR for uploading e2e results
3. Allows a public preset to be used in private accessmode with private
ACR path
4. Adds Validation check for count > 1 for Tuning

---------

Signed-off-by: Ishaan Sehgal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangqipropel bangqipropel bangqipropel approved these changes

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishaansehgal99 @Fei-Guo @bangqipropel