Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor Naming Conventions, Update Dependencies, Enhance Examples, and Add Volume Validation Check #470

Merged
merged 19 commits into from
Jun 18, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Jun 14, 2024

Reason for Change:
This PR includes a bunch of renaming and chore changes. It includes:

  1. Package renaming to avoid hyphens in package names for phi-2 and phi-3.
  2. Updating pip dependencies required for phi-3
  3. Use huggingface naming for plugins with hyphens
  4. Add phi3 to examples folder
  5. Readme: Update phi-3 example requests
  6. Change ConfigMapTemplate back to Config and update the comments
  7. Fix a device error encountered by inference API UTs by explicitly specifying device
  8. Raise not implemented error in validation for using volume

@ishaansehgal99 ishaansehgal99 changed the title fix: Rename Packages, Update Dependencies, and Improve Documentation for Phi-3 fix: Refactor Naming Conventions, Update Dependencies, Enhance Examples, and Improve Validation and Inference UT Device Handling Jun 18, 2024
@ishaansehgal99 ishaansehgal99 changed the title fix: Refactor Naming Conventions, Update Dependencies, Enhance Examples, and Improve Validation and Inference UT Device Handling fix: Refactor Naming Conventions, Update Dependencies, Enhance Examples, and Volume Validation Check Jun 18, 2024
@ishaansehgal99 ishaansehgal99 changed the title fix: Refactor Naming Conventions, Update Dependencies, Enhance Examples, and Volume Validation Check fix: Refactor Naming Conventions, Update Dependencies, Enhance Examples, and Add Volume Validation Check Jun 18, 2024
@ishaansehgal99 ishaansehgal99 merged commit f2b3504 into main Jun 18, 2024
11 of 15 checks passed
@ishaansehgal99 ishaansehgal99 deleted the demo branch June 18, 2024 18:37
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Jul 12, 2024
…es, and Add Volume Validation Check (kaito-project#470)

**Reason for Change**:
This PR includes a bunch of renaming and chore changes. It includes: 

1. Package renaming to avoid hyphens in package names for phi-2 and
phi-3.
2. Updating pip dependencies required for phi-3
3. Use huggingface naming for plugins with hyphens
4. Add phi3 to examples folder
5. Readme: Update phi-3 example requests 
6. Change ConfigMapTemplate back to Config and update the comments
7. Fix a device error encountered by inference API UTs by explicitly
specifying device
8. Raise not implemented error in validation for using volume
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants