-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refactor Naming Conventions, Update Dependencies, Enhance Examples, and Add Volume Validation Check #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fei-Guo
approved these changes
Jun 18, 2024
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Jul 12, 2024
…es, and Add Volume Validation Check (kaito-project#470) **Reason for Change**: This PR includes a bunch of renaming and chore changes. It includes: 1. Package renaming to avoid hyphens in package names for phi-2 and phi-3. 2. Updating pip dependencies required for phi-3 3. Use huggingface naming for plugins with hyphens 4. Add phi3 to examples folder 5. Readme: Update phi-3 example requests 6. Change ConfigMapTemplate back to Config and update the comments 7. Fix a device error encountered by inference API UTs by explicitly specifying device 8. Raise not implemented error in validation for using volume
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR includes a bunch of renaming and chore changes. It includes: