Don't use type: strz with terminator: (...)

See kaitai-io/ksy_schema#6 (comment) for a rationale. In fact, there is a JSON Schema constraint in ksy_schema to explicitly discourage this syntax (https://github.com/kaitai-io/ksy_schema/blob/e3a0398844734bf58789b9b8f08e3bc0c80a3274/ksy_schema.json#L466-L476).
kaitai-io · Mar 21, 2021 · d66edc7 · d66edc7
1 parent 97d68e9
commit d66edc7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/formats/nav_parent_vs_value_inst.ksy b/formats/nav_parent_vs_value_inst.ksy
@@ -5,7 +5,7 @@ meta:
 
 seq:
   - id: s1
-    type: strz
+    type: str
     encoding: UTF-8
     terminator: 0x7C
   - id: child

diff --git a/formats/opaque_external_type_02_child.ksy b/formats/opaque_external_type_02_child.ksy
@@ -4,11 +4,11 @@ meta:
   endian: le
 seq:
   - id: s1
-    type: strz
+    type: str
     encoding: UTF-8
     terminator: 0x7C
   - id: s2
-    type: strz
+    type: str
     encoding: UTF-8
     terminator: 0x7C
     consume: false
@@ -18,7 +18,7 @@ types:
   opaque_external_type_02_child_child:
     seq:
       - id: s3
-        type: strz
+        type: str
         encoding: UTF-8
         terminator: 0x40
         include: true

diff --git a/formats/term_strz.ksy b/formats/term_strz.ksy
@@ -3,16 +3,16 @@ meta:
   endian: le
 seq:
   - id: s1
-    type: strz
+    type: str
     encoding: UTF-8
     terminator: 0x7c
   - id: s2
-    type: strz
+    type: str
     encoding: UTF-8
     terminator: 0x7c
     consume: false
   - id: s3
-    type: strz
+    type: str
     encoding: UTF-8
     terminator: 0x40
     include: true
diff --git a/formats/to_string_custom.ksy b/formats/to_string_custom.ksy
@@ -6,7 +6,7 @@ seq:
     type: str
     terminator: 0x7c
   - id: s2
-    type: strz
+    type: str
     terminator: 0x7c
 to-string: |
   "s1 = " + s1 + ", s2 = " + s2