Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parchive v2 #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Aug 21, 2020

Cannot force-push to #69, so created a new one. @generalmimon, some of your proposals are implemented.

- id: placeholder
type: u1
repeat: until
repeat-until: _ == 0 or _io.pos == _io.size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified:

Suggested change
repeat-until: _ == 0 or _io.pos == _io.size
repeat-until: _ == 0 or _io.eof

@KOLANICH KOLANICH force-pushed the parchive_v2 branch 2 times, most recently from b0d9e67 to 39490fa Compare January 18, 2021 17:22
@KOLANICH KOLANICH force-pushed the parchive_v2 branch 3 times, most recently from 01d40e6 to 1f80935 Compare March 10, 2021 17:20
@KOLANICH KOLANICH force-pushed the parchive_v2 branch 2 times, most recently from 2467022 to 5728100 Compare April 19, 2021 18:09
@KOLANICH KOLANICH force-pushed the parchive_v2 branch 2 times, most recently from c236fcb to d779f79 Compare April 30, 2021 14:18
@KOLANICH KOLANICH force-pushed the parchive_v2 branch 3 times, most recently from c14d0e0 to d66663e Compare July 5, 2021 17:25
@KOLANICH KOLANICH force-pushed the parchive_v2 branch 2 times, most recently from 09d71d1 to 612cdfd Compare September 3, 2021 16:56
@KOLANICH KOLANICH force-pushed the parchive_v2 branch 2 times, most recently from 736b85c to 0736716 Compare September 14, 2021 18:52
@KOLANICH KOLANICH force-pushed the parchive_v2 branch 2 times, most recently from d30124d to 656d076 Compare October 28, 2021 17:28
@KOLANICH KOLANICH force-pushed the parchive_v2 branch 2 times, most recently from 71e7a72 to 893cdb4 Compare May 31, 2022 10:46
@KOLANICH KOLANICH force-pushed the parchive_v2 branch 2 times, most recently from f49b049 to fd1df40 Compare March 20, 2023 13:19
@KOLANICH KOLANICH force-pushed the parchive_v2 branch 2 times, most recently from 2ded142 to 5105a76 Compare March 28, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants