-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added parchive v2 #315
Open
KOLANICH
wants to merge
1
commit into
kaitai-io:master
Choose a base branch
from
KOLANICH-specs:parchive_v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added parchive v2 #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archive/parchive_v2.ksy
Outdated
- id: placeholder | ||
type: u1 | ||
repeat: until | ||
repeat-until: _ == 0 or _io.pos == _io.size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be simplified:
Suggested change
repeat-until: _ == 0 or _io.pos == _io.size | |
repeat-until: _ == 0 or _io.eof |
fd9f889
to
8335cba
Compare
a8edfbe
to
61df6bd
Compare
61df6bd
to
4739cc6
Compare
b0d9e67
to
39490fa
Compare
39490fa
to
5f73332
Compare
01d40e6
to
1f80935
Compare
2467022
to
5728100
Compare
c236fcb
to
d779f79
Compare
c14d0e0
to
d66663e
Compare
09d71d1
to
612cdfd
Compare
736b85c
to
0736716
Compare
d30124d
to
656d076
Compare
c54c819
to
f00791a
Compare
a5dba3a
to
ade67ed
Compare
71e7a72
to
893cdb4
Compare
f49b049
to
fd1df40
Compare
2ded142
to
5105a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot force-push to #69, so created a new one. @generalmimon, some of your proposals are implemented.