Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Lytro Light Field Picture #213
base: master
Are you sure you want to change the base?
Added Lytro Light Field Picture #213
Changes from all commits
6b4bd81
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of pointless to merge this into main KS repo, as this clearly requires these external modules, and (1) all the current infrastructure does not really support that, (2) I doubt that it's a good way to go for future development — the whole point of having KS specs was having cross-language support, and this particular implementation will be constrained to a single language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an example of missing pieces in python. It is pointless to insert there impls in all other langs. A user should look at the python code and implement something similar in the lang he uses. The rest of the spec is suitable for other langs (not necessarily all of them, IDK if the trick would work in C++, C# and Java).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if Python is a good language for that. There's a library I found where only a Python implementation existed, and it is becoming the hardest thing ever to port to Java.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we already know, the proper solution requres changes in KSC. But for now a temporary solution working at least somewhere is better than nothing.