Python packaging-related fixes: #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreyCat
reviewed
Jan 31, 2020
dgelessus
reviewed
Jan 31, 2020
GreyCat
reviewed
Jan 31, 2020
GreyCat
reviewed
Jan 31, 2020
GreyCat
reviewed
Jan 31, 2020
KOLANICH
force-pushed
the
python_fixes
branch
4 times, most recently
from
eabd27d to
eea55d8
Compare
generalmimon
reviewed
Aug 1, 2020
generalmimon
reviewed
Aug 1, 2020
generalmimon
reviewed
Aug 1, 2020
generalmimon
reviewed
Aug 1, 2020
generalmimon
reviewed
Aug 1, 2020
generalmimon
reviewed
Aug 1, 2020
generalmimon
reviewed
Aug 1, 2020
generalmimon
reviewed
Aug 1, 2020
generalmimon
reviewed
Aug 2, 2020
KOLANICH
force-pushed
the
python_fixes
branch
2 times, most recently
from
d7dceec to
829f637
Compare
generalmimon
reviewed
Aug 2, 2020
KOLANICH
force-pushed
the
python_fixes
branch
4 times, most recently
from
24cfd3a to
845442a
Compare
generalmimon
reviewed
Aug 2, 2020
generalmimon
reviewed
Aug 2, 2020
generalmimon
reviewed
Aug 2, 2020
generalmimon
reviewed
Aug 2, 2020
generalmimon
reviewed
Aug 2, 2020
generalmimon
reviewed
Aug 2, 2020
generalmimon
reviewed
Aug 2, 2020
KOLANICH
force-pushed
the
python_fixes
branch
4 times, most recently
from
7dbca63 to
5de69cf
Compare
generalmimon
reviewed
Aug 2, 2020
dgelessus
reviewed
Aug 2, 2020
KOLANICH
force-pushed
the
python_fixes
branch
6 times, most recently
from
263f049 to
878dc36
Compare
generalmimon
reviewed
Aug 2, 2020
generalmimon
reviewed
Aug 2, 2020
generalmimon
reviewed
Aug 2, 2020
generalmimon
approved these changes
Aug 2, 2020
There was a problem hiding this comment.
Looks good to me, thanks a lot for this massive effort, and especially for your awesome attitude to the review comments! The PR has improved a lot since your initial proposal, and you managed to address most of the suggestions in a single day. Great job!
What amazes me the most is that though I may be really annoying with the big pile of minor corrections, you never lose your temper and you even thank me for most of my findings. Thank you again for keeping the good mood here!
* improved the docs on installing python runtime * fixed the links to kaitaiStructCompile.setuptools * added more examples of usage of kaitaiStructCompile.setuptools Co-authored-by: Petr Pučil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes kaitai-io/kaitai_struct#692.