Check Python runtime version using tuple comparison instead of string parsing #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used pkg_resources.parse_version to parse the kaitaistruct module's __version__ string. Unfortunately, importing pkg_resources is relatively slow, which had a noticeable performance impact on every ksc-generated parser. The new implementation uses the newly added kaitaistruct.API_VERSION attribute, which stores the runtime version as a tuple of ints. In this format the version information can be compared directly without having to parse it from a string first. This allows removing the import of pkg_resources, which fixes the performance problem. Part of the fix for kaitai-io/kaitai_struct#804.
generalmimon
approved these changes
Apr 9, 2022
|
Well, I swear I knew a few minutes ago that I need to bump the versions by one (0.8->0.9 and 0.9->0.10) before merging this 😄, but no big deal, I'll do that right away. |
generalmimon
added a commit
that referenced
this pull request
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of one of the potential fixes for kaitai-io/kaitai_struct#804. Depends on kaitai-io/kaitai_struct_python_runtime#49.