Use expression parser to parse user type refs #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mingun Could you please rebase your branch |
Mingun
force-pushed
the
type-ref-parser
branch
2 times, most recently
from
b908d3a to
ab008d7
Compare
|
Rebased |
|
This makes absolute perfect sense. Overall, the idea is to use true parsers as much as possible, as opposed to regex-based parsing is a very good one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure the compiler tests were running. Unfortunately, there is nothing in the documentation about running tests and I can't find a @GreyCat post where he gave me some clues about it
Fixes kaitai-io/kaitai_struct#792