Fix scala.js deprecation warnings

kaitai-io · Nov 26, 2020 · d10b795 · d10b795
1 parent af69228
commit d10b795
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/build.sbt b/build.sbt
@@ -197,13 +197,13 @@ lazy val buildNpmJsFileTask = Def.task {
   val compiledFileContents = IO.read(compiledFile, UTF8)
 
   val fileWithExports =
-    s"""(function (root, factory) {
+    s"""(function (root, compiler) {
        |  if (typeof define === 'function' && define.amd) {
-       |    define([], factory);
+       |    define([], function() { return compiler; });
        |  } else if (typeof module === 'object' && module.exports) {
-       |    module.exports = factory();
+       |    module.exports = compiler;
        |  } else {
-       |    root.KaitaiStructCompiler = factory();
+       |    root.KaitaiStructCompiler = compiler;
        |  }
        |}(this, function () {
        |

diff --git a/js/src/main/scala/io/kaitai/struct/JavaScriptImporter.scala b/js/src/main/scala/io/kaitai/struct/JavaScriptImporter.scala
@@ -2,8 +2,10 @@ package io.kaitai.struct
 
 import scala.scalajs.js
 import scala.scalajs.js.Promise
+import scala.scalajs.js.annotation.JSGlobal
 
 @js.native
+@JSGlobal
 class JavaScriptImporter extends js.Object {
   def importYaml(name: String, mode: String): Promise[js.Object] = js.native
 }
diff --git a/js/src/main/scala/io/kaitai/struct/MainJs.scala b/js/src/main/scala/io/kaitai/struct/MainJs.scala
@@ -7,9 +7,9 @@ import scala.concurrent.ExecutionContext.Implicits.global
 import scala.concurrent.Future
 import scala.scalajs.js
 import scala.scalajs.js.JSConverters._
-import scala.scalajs.js.annotation.JSExport
+import scala.scalajs.js.annotation.{JSExport, JSExportTopLevel}
 
-@JSExport
+@JSExportTopLevel("MainJs")
 object MainJs {
   KSVersion.current = Version.version