Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support list in doc-ref #269

Closed
KOLANICH opened this issue Sep 26, 2017 · 5 comments
Closed

Support list in doc-ref #269

KOLANICH opened this issue Sep 26, 2017 · 5 comments
Labels
enhancement
Milestone
v0.9

Comments

@KOLANICH
Copy link

No description provided.

@GreyCat
Copy link
Member

GreyCat commented Sep 26, 2017

I'm really inclined to close these one-liner "issues" right away without any comments, if you don't want to spend a minute and explain what is it about, why is this important, and in which cases you need such support.

@KOLANICH
Copy link
Author

It's obvious: information about the format can be taken from multiple sources.

@GreyCat GreyCat mentioned this issue Jan 21, 2018
Merged
@GreyCat GreyCat modified the milestones: v0.10, v0.9 Apr 17, 2019
@GreyCat
Copy link
Member

GreyCat commented Apr 19, 2019

I've implemented it. Now doc-ref accepts both string and a list of strings: kaitai-io/kaitai_struct_compiler@f2c12d4

New test is called DocstringsDocrefMulti and will appear shortly at CI. KST is there, but it is essentially no-op, as we can't test it automatically.

@GreyCat
Copy link
Member

GreyCat commented Apr 25, 2019

Most of languages are commited, so considering this done.

@GreyCat GreyCat closed this as completed Apr 25, 2019
@KOLANICH
Copy link
Author

Thank you.

@KOLANICH KOLANICH mentioned this issue Apr 27, 2019
Open
@dgelessus dgelessus mentioned this issue Apr 29, 2019
Merged
generalmimon added a commit to kaitai-io/ksy_schema that referenced this issue Dec 7, 2019
@generalmimon
Allow list of strings in doc-ref
60a2fa9 
See kaitai-io/kaitai_struct#269
@generalmimon generalmimon mentioned this issue Dec 7, 2019
Merged
@generalmimon generalmimon mentioned this issue May 3, 2020
Closed
@generalmimon generalmimon mentioned this issue Jun 27, 2020
Open
@generalmimon generalmimon mentioned this issue Oct 16, 2020
Merged
@generalmimon generalmimon mentioned this issue Mar 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.9
Development

No branches or pull requests
2 participants
@GreyCat @KOLANICH