Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Return array/object instead string when possible #97

Closed
wants to merge 1 commit into from

Conversation

Jerome1337
Copy link
Contributor

Fixes #83

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test

Returns object or array instead flatted object. Objects are not flatted anymore, plain JavaScript object is returned.

Strings {variable} are still working, even in nested objects.

  • Write some docs

@kaisermann
Copy link
Owner

Hey, 👋 Thanks for starting your contribution. However, as this is a draft for quite a while, I'm closing this in favor of #105.

@kaisermann kaisermann closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loop on array of objects
2 participants