Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add palette of the XKCD color survey #3

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Add palette of the XKCD color survey #3

merged 1 commit into from
Jul 1, 2024

Conversation

m-haug
Copy link
Contributor

@m-haug m-haug commented May 27, 2024

No description provided.

@kaarmu
Copy link
Owner

kaarmu commented Jul 1, 2024

Thanks! I just have one suggestion, I'd like the color names to be kebab-case so it is natural to access them as fields.

@m-haug
Copy link
Contributor Author

m-haug commented Jul 1, 2024

I've changed most colour names to use kebap-case. The only exception is colours which contain slashes (blue/green) because often the two obvious alternatives (bluegreen and blue-green) are also already part of the dataset.

@kaarmu
Copy link
Owner

kaarmu commented Jul 1, 2024

Thanks!

@kaarmu kaarmu merged commit 1f96d38 into kaarmu:main Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants