Add support for struct types and different type kind nesting #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k94ll13nn3
approved these changes
Nov 23, 2023
|
Hey, thanks a lot for the struct support, it looks good. |
|
@k94ll13nn3 that's awesome, thank you for the quick review! 😄 |
|
Thanks again, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! I'm looking into using AutoConstructor for my unit tests in https://github.com/Sergio0694/ComputeSharp, but I realized I was missing a couple features for this to work. Specifically, support for struct types and nested types of different kinds. It seems like the support for all this was almost there already, so this PR just includes a few tweaks to get all that to work 🙂
The changes here are these two things:
[AutoConstructor]also support struct types, and updating the generatorAlso added a bunch of unit tests to cover the new scenarios.