-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network-status: add GW info #42
network-status: add GW info #42
Conversation
@maiqueb thank you for the PR, however can we hold this PR for now? So we need to fix |
Of course. I just wanted to kick this off the ground, and this seemed the easiest way ( to me ...) . |
Turns out that we actually had the examples in the spec! I went to go make a spec update last week, and... Alas, it's already there. Then... I realize Miguel already has the code here :D Amazing! So, I think we should probably be ready to merge. |
I think we might also want to merge against the release-v1.1 branch, too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, shoot, we need this
Signed-off-by: Miguel Duarte Barroso <[email protected]>
48e9d79
to
4df3b50
Compare
@dougbtv can we revisit this ? AFAIU, the IPv6 thing was addressed in multus. If not, I would appreciate if this PR were updated with the reasons it is being held. Because honestly, right now ... I don't know why. |
Hold this PR until
default-route
feature is fixed in spec (multi-net-spec) and multus-cni (comment by @s1061123, Nov 22, 2021)--
The GW information is missing from the
NetworkStatus
annotation.As such, it isn't possible to know which interface currently holds the default route.