Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration api route #459

Merged
merged 2 commits into from
May 25, 2023

Conversation

matthisholleville
Copy link
Contributor

Closes #449

πŸ“‘ Description

Initialize the configuration API route and add cache support

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Examples :

AddCache :

grpcurl -plaintext -d '{
  "cache": {
    "region": "us-west-1",
    "bucketName": "my-cache-bucket"
  }
}' localhost:8080 schema.v1.Server/AddConfig

{
  "status": "Configuration updated."
}

RemoveCache :

grpcurl -plaintext -d '{
  "cache": {
    "bucketName": "my-cache-bucket"
  }
}' localhost:8080 schema.v1.Server/RemoveConfig

{
  "status": "Successfully removed the remote cache"
}

@matthisholleville matthisholleville requested review from a team as code owners May 24, 2023 20:58
Signed-off-by: Matthis Holleville <[email protected]>
@AlexsJones
Copy link
Member

k8sgpt on ξ‚  feat/init-cache-api [$] via 🐹 v1.20.4 on ☁️  (eu-west-1)
❯ grpcurl -plaintext -d '{
  "cache": {
    "bucketName": "foobark8sgpt1"
  }
}' localhost:8080 schema.v1.Server/RemoveConfig

Error invoking method "schema.v1.Server/RemoveConfig": target server does not expose service "schema.v1.Server"

@matthisholleville I tried this by checking your PR out, anything I am doing wrong here?

pkg/cache/cache.go Outdated Show resolved Hide resolved
pkg/cache/cache.go Outdated Show resolved Hide resolved
Signed-off-by: Matthis Holleville <[email protected]>
@matthisholleville
Copy link
Contributor Author

Try this @AlexsJones :

grpcurl -plaintext -d '{
  "cache": {
    "bucketName": "foobark8sgpt1"
  }
}' localhost:8080 schema.v1.ServerService/RemoveConfig

grpcurl -plaintext -d '{
  "cache": {
    "region": "us-west-1",
    "bucketName": "my-cache-bucket"
  }
}' localhost:8080 schema.v1.ServerService/AddConfig

@AlexsJones AlexsJones merged commit fa4a075 into k8sgpt-ai:main May 25, 2023
golgoth31 pushed a commit to golgoth31/k8sgpt that referenced this pull request May 27, 2023
* feat: add configuration api route

Signed-off-by: Matthis Holleville <[email protected]>

* feat: rename cache methods

Signed-off-by: Matthis Holleville <[email protected]>

---------

Signed-off-by: Matthis Holleville <[email protected]>
Signed-off-by: David Sabatie <[email protected]>
golgoth31 pushed a commit to golgoth31/k8sgpt that referenced this pull request May 28, 2023
* feat: add configuration api route

Signed-off-by: Matthis Holleville <[email protected]>

* feat: rename cache methods

Signed-off-by: Matthis Holleville <[email protected]>

---------

Signed-off-by: Matthis Holleville <[email protected]>
Signed-off-by: David Sabatie <[email protected]>
AlexsJones added a commit that referenced this pull request May 31, 2023
* fix(deps): update module github.com/aws/aws-sdk-go to v1.44.267 (#451)

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: David Sabatie <[email protected]>

* feat: get official field doc

Signed-off-by: David Sabatie <[email protected]>

* feat: use schema from server

Signed-off-by: David Sabatie <[email protected]>

* feat: add configuration api route (#459)

* feat: add configuration api route

Signed-off-by: Matthis Holleville <[email protected]>

* feat: rename cache methods

Signed-off-by: Matthis Holleville <[email protected]>

---------

Signed-off-by: Matthis Holleville <[email protected]>
Signed-off-by: David Sabatie <[email protected]>

* fix(deps): update module github.com/aws/aws-sdk-go to v1.44.269 (#458)

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: David Sabatie <[email protected]>

* fix: updated list.go to handle k8sgpt cache list crashing issue (#455)

* Update list.go

Signed-off-by: Krishna Dutt Panchagnula <[email protected]>

* fix: updated list.go to handle k8sgpt cache list crashing issue

Signed-off-by: Krishna Dutt Panchagnula <[email protected]>

---------

Signed-off-by: Krishna Dutt Panchagnula <[email protected]>
Co-authored-by: Alex Jones <[email protected]>
Signed-off-by: David Sabatie <[email protected]>

* chore(main): release 0.3.5 (#452)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: David Sabatie <[email protected]>

* chore(deps): update google-github-actions/release-please-action digest to 51ee8ae (#464)

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: David Sabatie <[email protected]>

* fix: name of sa reference in deployment (#468)

Signed-off-by: Johannes Kleinlercher <[email protected]>
Signed-off-by: David Sabatie <[email protected]>

* fix(deps): update module github.com/aws/aws-sdk-go to v1.44.270 (#465)

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: David Sabatie <[email protected]>

* fix: typo (#463)

Signed-off-by: Rakshit Gondwal <[email protected]>
Co-authored-by: Thomas Schuetz <[email protected]>
Signed-off-by: David Sabatie <[email protected]>

* fix(deps): update module github.com/aws/aws-sdk-go to v1.44.271 (#469)

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: David Sabatie <[email protected]>

* fix(deps): update module github.com/aws/aws-sdk-go to v1.44.269 (#458)

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update module github.com/aws/aws-sdk-go to v1.44.270 (#465)

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: David Sabatie <[email protected]>

* fix(deps): update module github.com/aws/aws-sdk-go to v1.44.271 (#469)

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: David Sabatie <[email protected]>

* feat: Add with-doc flag to enable/disable kubernetes doc

Signed-off-by: David Sabatie <[email protected]>

* use fmt.Sprintf in apireference.go

Signed-off-by: David Sabatie <[email protected]>

* add --with-doc to readme

Signed-off-by: David Sabatie <[email protected]>

---------

Signed-off-by: Renovate Bot <[email protected]>
Signed-off-by: David Sabatie <[email protected]>
Signed-off-by: Matthis Holleville <[email protected]>
Signed-off-by: Krishna Dutt Panchagnula <[email protected]>
Signed-off-by: Johannes Kleinlercher <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: golgoth31 <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matthis <[email protected]>
Co-authored-by: Krishna Dutt Panchagnula <[email protected]>
Co-authored-by: Alex Jones <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Johannes Kleinlercher <[email protected]>
Co-authored-by: Rakshit Gondwal <[email protected]>
Co-authored-by: Thomas Schuetz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Support remote cache through API
2 participants