Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use hpa namespace instead analyzer namespace #230

Merged

Conversation

matthisholleville
Copy link
Contributor

Closes #229 #216

πŸ“‘ Description

Fixed a bug that did not retrieve the correct namespace when analyzing HPA.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@matthisholleville matthisholleville requested a review from a team as a code owner April 9, 2023 21:58
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit a582d44 into k8sgpt-ai:main Apr 10, 2023
patrickpichler pushed a commit to patrickpichler/k8sgpt that referenced this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

User experience around the optional filter
2 participants