Add prometheus scraping also for external-dns and coredns pods #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jirka Kremser <[email protected]>
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
make deploy-prometheusis run, the Prometheus scrapes onlyk8gband podinfo app. This PR adds the scraping also for external-dns pod and coredns pod.http://127.0.0.1:9081/targets(after this change):make deploy-prometheus ... Set annotations on pods that will be scraped by prometheus pod/k8gb-746d98857d-7tq4d annotated pod/external-dns-6bd44c4856-pcdt2 annotated pod/k8gb-coredns-5bc6689949-5f8jn annotated ... make uninstall-prometheus ... uninstall prometheus release "prometheus" uninstalled pod/k8gb-746d98857d-7tq4d annotated pod/external-dns-6bd44c4856-pcdt2 annotated pod/k8gb-coredns-5bc6689949-5f8jn annotated ...Also small change to the readme, because the port was moved couple of months ago.
Signed-off-by: Jirka Kremser [email protected]