unset deprecated envvars #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #835 EDGE_DNS_SERVER, EDGE_DNS_SERVER_PORT are deprecated. We still keep them because of previous versions of k8gb and set them explicitly in tests. We have several tests which are inspecting deprecated variables, and count with them to be unset. Such tests creates and assert them if needed. This patch ensures that the variables will not be set before running the tests. I tested with all supported environment variables in `.env` file: ```env RECONCILE_REQUEUE_SECONDS=dummy CLUSTER_GEO_TAG=dummy EXT_GSLB_CLUSTERS_GEO_TAGS=dummy EXTDNS_ENABLED=dummy EDGE_DNS_SERVERS=dummy EDGE_DNS_ZONE=dummy DNS_ZONE=dummy INFOBLOX_GRID_HOST=dummy INFOBLOX_WAPI_VERSION=dummy INFOBLOX_WAPI_PORT=dummy INFOBLOX_WAPI_USERNAME=dummy INFOBLOX_WAPI_PASSWORD=dummy INFOBLOX_HTTP_REQUEST_TIMEOUT=dummy INFOBLOX_HTTP_POOL_CONNECTIONS=dummy POD_NAMESPACE=dummy COREDNS_EXPOSED=dummy LOG_LEVEL=dummy LOG_FORMAT=dummy NO_COLOR=dummy SPLIT_BRAIN_CHECK=dummy METRICS_ADDRESS=dummy EDGE_DNS_SERVER=8.8.8.8 EDGE_DNS_SERVER_PORT=53 ``` Signed-off-by: kuritka <[email protected]>
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
somaritane
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #835
EDGE_DNS_SERVER,EDGE_DNS_SERVER_PORTare deprecated.We still keep them because of previous versions of k8gb and set
them explicitly in tests. We have several tests which are inspecting deprecated variables, and count with them to be initially unset. Such tests creates and assert them if needed.
This patch ensures that the variables will not be set before running the tests.
I tested with all supported environment variables in
.envfile:Signed-off-by: kuritka [email protected]