Allow to change dnsPolicy of ExternalDNS deployment #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jirka Kremser <[email protected]>
jkremser
requested review from
donovanmuller,
k0da,
kuritka and
ytsarev
as code owners
kuritka
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why?
When deploying k8gb to vanilla k8s clusters that were created using cluster API and kubeadm (no EKS, no managed control planes).
The ExternalDNS deployment has an issue with resolving
route53.amazonaws.com. By default the dnsPolicy if not specified isClusterFirstso this PR is a no-op in terms of backward compatibility, but if changed toDefaultthis fixed the previous situation for me. I guess, this can be solved also by tweaking the dns server for this k8s cluster or by providing own corefile for coredns, but it can't hurt either to allow this easy fix.docs
Default... use host for resolving the dns namesClusterFirst... Any DNS query that does not match the configured cluster domain suffix, such as "www.kubernetes.io", is forwarded to an upstream nameserver by the DNS server. Cluster administrators may have extra stub-domain and upstream DNS servers configured.more context:
i have to do ugly hacks because of it :D