Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 932 - ingress annotations accept external changes #1019

Closed
wants to merge 1 commit into from
Closed

Fix 932 - ingress annotations accept external changes #1019

wants to merge 1 commit into from

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Nov 7, 2022 •
edited
Loading

closes #932
related to #1018

  • Fixed implementation. In some cases, when the ingress was changed, reconciliation was triggered, which changed the annotations back to the values calculated with GSLB. I modified the merge function to filter which values should be synced and which should not. In fact, it is only k8gb.io/strategy and k8gb.io/primary-geotag that are changed on initialization.
  • utit tests update
  • terratests are focused on repeated patching of annotations in ingress and examining ingress when patching annotations in GSLB

Signed-off-by: kuritka [email protected]

k0da
k0da reviewed Nov 7, 2022
View reviewed changes
terratest/utils/extensions.go Outdated Show resolved Hide resolved
@kuritka
Fix 932 - ingress annotations accept external changes
255179a 
closes #932
related to #1018

 - Implementation: In some cases, when the ingress was changed, reconciliation was triggered, which changed the annotations back to the values calculated with GSLB. I modified the merge function to filter which values should be synced and which should not. In fact, it is only `k8gb.io/strategy` and `k8gb.io/primary-geotag` that are changed on initialization.
 - Utit tests update
 - Terratests are focused on repeated patching of annotations in ingress and examining ingress when patching annotations in GSLB

Signed-off-by: kuritka <[email protected]>
@kuritka kuritka marked this pull request as draft November 8, 2022 14:51
@kuritka kuritka mentioned this pull request Mar 19, 2023
Closed
@kuritka kuritka mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0da k0da k0da left review comments

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@somaritane somaritane Awaiting requested review from somaritane

@ytsarev ytsarev Awaiting requested review from ytsarev ytsarev is a code owner

@jkremser jkremser Awaiting requested review from jkremser jkremser is a code owner

@abaguas abaguas Awaiting requested review from abaguas abaguas will be requested when the pull request is marked ready for review abaguas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] GSLB is not updated when Ingress has change
2 participants
@kuritka @k0da