-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for env *_PROXY variables for agent loadbalancer #9070
Conversation
Signed-off-by: Yodo <[email protected]>
After destroying accidentally #8982, here's the new PR with requested changes, really sorry about the mess. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #9070 +/- ##
==========================================
- Coverage 46.24% 41.59% -4.66%
==========================================
Files 148 148
Lines 15924 15954 +30
==========================================
- Hits 7364 6636 -728
- Misses 7374 8185 +811
+ Partials 1186 1133 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yodo <[email protected]>
Signed-off-by: Yodo <[email protected]>
Signed-off-by: Yodo <[email protected]>
Signed-off-by: Yodo <[email protected]> Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Yodo <[email protected]> Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Yodo <[email protected]> Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Yodo <[email protected]> Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Yodo <[email protected]> Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Yodo <[email protected]> Signed-off-by: Derek Nola <[email protected]>
Types of Changes
To me, this is a bugfix as the doc specifies we can use these env variables for k3s: https://docs.k3s.io/advanced#configuring-an-http-proxy.
There is also this documentation that may be misleading as it suggests that in addition to proxies, you should open your network to various URLs, which is incompatible: https://docs.k3s.io/installation/requirements#networking.
Verification
You can test the new agent on a airgapped environment, where internet access is only possible through an external proxy.
This was tested in production on such environment on my end.
Testing
There are no linked unit tests as this is the first time I'm working on Go.
Linked Issues
Linked issue is: #8976
User-Facing Change
Further Comments
As this is a known issue for net.Dialer, this fix is based on another library which can be found on: https://github.com/mwitkow/go-http-dialer