Fix nil map in full snapshot configmap reconcile #9049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorsavian
approved these changes
Dec 13, 2023
brandond
force-pushed
the
fix-etcd-nil-map
branch
from
1b131a0 to
e124f91
Compare
dereknola
approved these changes
Jan 2, 2024
brandond
force-pushed
the
fix-etcd-nil-map
branch
from
e124f91 to
0788e5b
Compare
If a full reconcile wins the race against sync of an individual snapshot resource, or someone intentionally deletes the configmap, the data map could be nil and cause a crash. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-etcd-nil-map
branch
from
0788e5b to
39bf579
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #9049 +/- ##
==========================================
- Coverage 41.56% 41.51% -0.05%
==========================================
Files 148 148
Lines 15946 15949 +3
==========================================
- Hits 6628 6622 -6
- Misses 8189 8196 +7
- Partials 1129 1131 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
If a full reconcile wins the race against sync of an individual snapshot resource, or someone intentionally deletes the configmap, the data map could be nil and cause a crash.
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments