Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.27] Add RWMutex to address controller #8273

Merged

Conversation

brandond
Copy link
Member

Proposed Changes

Add RWMutex to address controller

Fixes race condition when address map is updated by multiple goroutines

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Further Comments

Fixes race condition when address map is updated by multiple goroutines

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 0d23cfe)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner August 30, 2023 06:10
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.26% 🎉

Comparison is base (f365a9c) 47.28% compared to head (b0808ac) 51.54%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #8273      +/-   ##
================================================
+ Coverage         47.28%   51.54%   +4.26%     
================================================
  Files               144      144              
  Lines             14622    14628       +6     
================================================
+ Hits               6914     7540     +626     
+ Misses             6607     5893     -714     
- Partials           1101     1195      +94     
Flag Coverage Δ
e2etests 49.07% <0.00%> (?)
inttests 44.48% <0.00%> (-0.12%) ⬇️
unittests 19.90% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/cluster/address_controller.go 0.00% <0.00%> (ø)

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 8d074ec into k3s-io:release-1.27 Aug 30, 2023
@brandond brandond deleted the fix-filtercn-map_release-1.27 branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants