add --disable-cloud-controller and --disable-kube-proxy test #8018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #8018 +/- ##
==========================================
+ Coverage 47.69% 49.76% +2.06%
==========================================
Files 143 140 -3
Lines 14564 14499 -65
==========================================
+ Hits 6947 7216 +269
+ Misses 6485 6082 -403
- Partials 1132 1201 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
requested changes
Jul 20, 2023
osodracnai
force-pushed
the
add-disable-flag-tests
branch
from
5fb5786 to
f170ce6
Compare
brandond
reviewed
Jul 20, 2023
osodracnai
force-pushed
the
add-disable-flag-tests
branch
2 times, most recently
from
8dbc030 to
40aa8a0
Compare
dereknola
requested changes
Jul 20, 2023
Signed-off-by: Ian Cardoso <[email protected]>
osodracnai
force-pushed
the
add-disable-flag-tests
branch
from
40aa8a0 to
a737a95
Compare
dereknola
approved these changes
Jul 21, 2023
brandond
approved these changes
Jul 24, 2023
johnatasr
approved these changes
Jul 26, 2023
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Aug 4, 2023
…8018) Signed-off-by: Ian Cardoso <[email protected]> (cherry picked from commit 53fc3ee)
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Aug 4, 2023
…8018) Signed-off-by: Ian Cardoso <[email protected]> (cherry picked from commit 53fc3ee)
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Aug 4, 2023
…8018) Signed-off-by: Ian Cardoso <[email protected]> (cherry picked from commit 53fc3ee)
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Aug 4, 2023
…8018) Signed-off-by: Ian Cardoso <[email protected]> (cherry picked from commit 53fc3ee)
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Aug 4, 2023
…8018) Signed-off-by: Ian Cardoso <[email protected]> (cherry picked from commit 53fc3ee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PRs adds integration tests for 2 flags:
--disable-kube-proxy
--disable-cloud-controller
reference issue: #6057
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments