update rootlesskit to 1.0.1 #5773
Conversation
dirkmueller
force-pushed
the
uroot_breakfix
branch
from
8d3b9dc to
a48e081
Compare
go.mod
Outdated
| @@ -104,7 +104,7 @@ require ( | |||
| github.com/rancher/wharfie v0.5.1 | |||
| github.com/rancher/wrangler v1.0.0 | |||
| github.com/robfig/cron/v3 v3.0.1 | |||
| github.com/rootless-containers/rootlesskit v0.14.5 | |||
| github.com/rootless-containers/rootlesskit v0.14.6 | |||
There was a problem hiding this comment.
Any reason not to use v1.0.1?
There was a problem hiding this comment.
from a "what makes sense" perspective going with newest makes most sense, but it is a much larger jump. pushed now.
dirkmueller
force-pushed
the
uroot_breakfix
branch
from
a48e081 to
4b38dd8
Compare
dirkmueller
force-pushed
the
uroot_breakfix
branch
from
4b38dd8 to
419cae5
Compare
|
so it looks like 1.0.1 is failing on the arm architecture. going back to 0.14.6 to confirm |
dirkmueller
force-pushed
the
uroot_breakfix
branch
from
419cae5 to
c3600a2
Compare
What was the error? |
|
I think the failure with 1.0.1 was just a CI flake. Your other PR for 1.x.x seems to be passing at the moment. |
the other PR is using 1.0.0, not 1.0.1, which passes. 1.0.1 still fails. |
dirkmueller
force-pushed
the
uroot_breakfix
branch
from
c3600a2 to
31a0183
Compare
|
I'm a little confused, you appear to be updating both this PR and #5788 - which one would you like to move forward with? |
This avoids an issue with u-root 7.0.0 which has been retracted by the author: $ go list -u -m all $ go list -m: github.com/u-root/[email protected]+incompatible: retracted by module author: Published v7 too early (before migrating to go modules) Signed-off-by: Dirk Müller <[email protected]>
dirkmueller
force-pushed
the
uroot_breakfix
branch
from
31a0183 to
d184cc6
Compare
the other one was just for testing the CI. You were right, the previous failure appeared to be a CI fluke, so this is good to go. |
This avoids an issue with u-root 7.0.0 which has been pulled:
$ go list -u -m all
$ go list -m: github.com/u-root/[email protected]+incompatible: retracted by module author: Published v7 too early (before migrating to go modules)
Proposed Changes
This enables outdated-dependency check to work again and not fail on a retracted module.
Types of Changes
Bugfix
Verification
CI passes
Linked Issues
User-Facing Change
Further Comments