Add opened_only matcher for security groups. #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matcher allows the user to make exclusivity statements about certain rules. Prior, a user could only make statements about the existence of opened rules for security groups, now they can state that not only is there an opened rule but that that is the _only_ open rule for a given port, protocol, cidr.
|
Thank you for your contribution!
You are right.... It is worthy of consideration.
Its nice idea. and I want its(:outbound) { should be_opened_only(50_000).protocol('tcp').for(%w(100.456.789.012/32 200.567.890.123/32)) } |
|
@k1LoW That last commit should allow arbitrary numbers of cidrs. :) |
|
Great commit!! |
k1LoW
added a commit
that referenced
this pull request
Feb 19, 2016
Add opened_only matcher for security groups.
|
Released as v0.33.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how well this fits in with the overall development plan. My company needs this for our use of awspec, and it seems silly not to contribute back to core. I'd be happy to make any changes y'all see fit, or move it into a plugin-type infrastructure if you have that. Please let me know!
This matcher allows the user to make exclusivity statements about certain rules.
Prior, a user could only make statements about the existence of opened rules for
security groups, now they can state that not only is there an opened rule but that
that is the only open rule for a given port, protocol.
The specs and stubs were reworked only to ensure testability of this new matcher without creating any new stubs. Again, happy to go in a different direction if you're up for larger scale changes to the organization of the specs/stubs.