Remove unneeded status update since we now update the status via defe… #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r func This puts the controller into update failing "loop" since we now update the status twice from same reconciliation round. Signed-off-by: Jussi Nummelin <[email protected]>
|
I think the proposed change is correct since the status update is done in the defer but I have tested and still encounter the problem sometimes. I think this issue is similar to #921. I have tried using a As a side note, in other patching operations for other resources we are also encountering this problem. I have not seen it in depth but maybe we should take a look at using https://pkg.go.dev/sigs.k8s.io/[email protected]/util/patch in the future to handle these updates. |
makhov
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r func
This puts the controller into update failing "loop" since we now update the status twice from same reconciliation round.