-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH action to lint markdown files #925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmingacic
previously approved these changes
May 24, 2021
Signed-off-by: Kimmo Lehto <[email protected]> Add github workflow for linting markdown Signed-off-by: Kimmo Lehto <[email protected]> Finetuning Signed-off-by: Kimmo Lehto <[email protected]> More tuning Signed-off-by: Kimmo Lehto <[email protected]> Path? Signed-off-by: Kimmo Lehto <[email protected]> Huge amount of manual fixes Signed-off-by: Kimmo Lehto <[email protected]> Second batch Signed-off-by: Kimmo Lehto <[email protected]> Third batch Signed-off-by: Kimmo Lehto <[email protected]> Does it need four indent? Signed-off-by: Kimmo Lehto <[email protected]> Maybe passes now Signed-off-by: Kimmo Lehto <[email protected]> Markdown is serious business Signed-off-by: Kimmo Lehto <[email protected]> Should be the last error Signed-off-by: Kimmo Lehto <[email protected]>
Merged
jasmingacic
approved these changes
May 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks legit
jnummelin
pushed a commit
to jnummelin/k0s
that referenced
this pull request
Jun 10, 2021
Signed-off-by: Kimmo Lehto <[email protected]> Add github workflow for linting markdown Signed-off-by: Kimmo Lehto <[email protected]> Finetuning Signed-off-by: Kimmo Lehto <[email protected]> More tuning Signed-off-by: Kimmo Lehto <[email protected]> Path? Signed-off-by: Kimmo Lehto <[email protected]> Huge amount of manual fixes Signed-off-by: Kimmo Lehto <[email protected]> Second batch Signed-off-by: Kimmo Lehto <[email protected]> Third batch Signed-off-by: Kimmo Lehto <[email protected]> Does it need four indent? Signed-off-by: Kimmo Lehto <[email protected]> Maybe passes now Signed-off-by: Kimmo Lehto <[email protected]> Markdown is serious business Signed-off-by: Kimmo Lehto <[email protected]> Should be the last error Signed-off-by: Kimmo Lehto <[email protected]> Co-authored-by: Kimmo Lehto <[email protected]>
mikhail-sakhnov
pushed a commit
to mikhail-sakhnov/k0s
that referenced
this pull request
Jun 28, 2021
Signed-off-by: Kimmo Lehto <[email protected]> Add github workflow for linting markdown Signed-off-by: Kimmo Lehto <[email protected]> Finetuning Signed-off-by: Kimmo Lehto <[email protected]> More tuning Signed-off-by: Kimmo Lehto <[email protected]> Path? Signed-off-by: Kimmo Lehto <[email protected]> Huge amount of manual fixes Signed-off-by: Kimmo Lehto <[email protected]> Second batch Signed-off-by: Kimmo Lehto <[email protected]> Third batch Signed-off-by: Kimmo Lehto <[email protected]> Does it need four indent? Signed-off-by: Kimmo Lehto <[email protected]> Maybe passes now Signed-off-by: Kimmo Lehto <[email protected]> Markdown is serious business Signed-off-by: Kimmo Lehto <[email protected]> Should be the last error Signed-off-by: Kimmo Lehto <[email protected]> Co-authored-by: Kimmo Lehto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kimmo Lehto [email protected]
Adds a Markdown linter into github actions and fixes linting errors to make it pass.
##
straight to####
without###
in between, heading used to create bold?)$
, when they do not display any output, the$
is omitted to ease copypasting)These are all things the linter will check for.
It was a lot of trouble to make it pass, but I'd say it's worth it because obvious mistakes were catched and will be automatically catched from now on (also forced linting makes diffs smaller).