Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Pi-5 k0s installation instructions #5513

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

ramessesii2
Copy link
Contributor

Description

This PR adds Raspberry Pi 5 guide for installing k0s.

Fixes # (issue)

Type of change

  • Documentation update

How Has This Been Tested?

  • Manual test

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ramessesii2 ramessesii2 requested review from a team as code owners February 4, 2025 18:18
@ramessesii2 ramessesii2 requested review from makhov and twz123 February 4, 2025 18:18
Copy link

@PrashantR30 PrashantR30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good @ramessesii2

twz123
twz123 previously approved these changes Feb 5, 2025
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot.

Just left some minor formal style nits.

docs/raspberry-pi5.md Outdated Show resolved Hide resolved
docs/raspberry-pi5.md Outdated Show resolved Hide resolved
docs/raspberry-pi5.md Outdated Show resolved Hide resolved
docs/raspberry-pi5.md Outdated Show resolved Hide resolved
docs/raspberry-pi5.md Outdated Show resolved Hide resolved
docs/raspberry-pi5.md Outdated Show resolved Hide resolved
docs/raspberry-pi5.md Outdated Show resolved Hide resolved
docs/raspberry-pi5.md Outdated Show resolved Hide resolved
docs/raspberry-pi5.md Outdated Show resolved Hide resolved
docs/raspberry-pi5.md Outdated Show resolved Hide resolved
@twz123 twz123 added the documentation Improvements or additions to documentation label Feb 5, 2025
Co-authored-by: Tom Wieczorek <[email protected]>
Signed-off-by: Satyam Bhardwaj <[email protected]>
@ramessesii2 ramessesii2 force-pushed the RAMESSES/pi-5-instructions branch from affd234 to 03e9ff3 Compare February 6, 2025 04:17
@ramessesii2
Copy link
Contributor Author

Thanks @PrashantR30 and @twz123 for the quick feedback.
I've merged your suggestions as well Tom.

@twz123 twz123 enabled auto-merge February 6, 2025 07:30
@twz123
Copy link
Member

twz123 commented Feb 6, 2025

Now that I co-authored this, someone else needs to approve ... 👼

@ramessesii2
Copy link
Contributor Author

@jnummelin please help reviewing.

Copy link
Member

@jnummelin jnummelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as all the comments from @twz123 are incorporated

@twz123 twz123 merged commit fdb5c2b into k0sproject:main Feb 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants