Revert "Remove default-config and validate sub-commands" #5479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
force-pushed
the
revert-5376-remove-deprecated-subcommands
branch
2 times, most recently
from
11555f3 to
a056eb1
Compare
cmd/validate/validate.go
Outdated
| @@ -0,0 +1,43 @@ | |||
| /* | |||
| Copyright 2021 k0s authors | |||
There was a problem hiding this comment.
The copyright linter complains about this https://github.com/k0sproject/k0s/blob/main/hack/copyright.sh#L23-L25
We could either remove the -1 flag from git log in the copyright script and then it works, or we can update the copyright to 2025.
There was a problem hiding this comment.
Damn. Did a force push and forgot to add the local change first ... that's what you get when you're in a hurry ... 😞
Signed-off-by: Tom Wieczorek <[email protected]>
twz123
force-pushed
the
revert-5376-remove-deprecated-subcommands
branch
from
a056eb1 to
5310ef9
Compare
jnummelin
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5376
There's a bug in k0sproject/version that causes k0sctl's version-based detection to make false assumptions about the supported sub-commands in k0s. That needs to be addressed first before we can remove these deprecated commands for realz.