Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remnants of latest k0s Docker image tags in docs #3597

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Remove remnants of latest k0s Docker image tags in docs #3597

merged 1 commit into from
Oct 18, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 18, 2023

Description

There are still some mentions of the latest tag for the k0s Docker image in the docs. Remove them.

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Remove remnants of latest k0s Docker image tags in docs
91893d5 
There are _still_ some mentions of the latest tag for the k0s Docker
image in the docs. Remove them.

Fixes: 40faf50 ("Don't mention latest Docker tag in docs")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added documentation Improvements or additions to documentation chore backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch labels Oct 18, 2023
@twz123 twz123 requested a review from a team as a code owner October 18, 2023 11:01
@twz123 twz123 requested review from makhov and jnummelin October 18, 2023 11:01
@twz123 twz123 merged commit c43f019 into k0sproject:main Oct 18, 2023
@twz123 twz123 deleted the no-latest-k0s-docker-tag branch October 18, 2023 13:48
@k0s-bot
Copy link

k0s-bot commented Oct 18, 2023

Successfully created backport PR for release-1.28:

@k0s-bot k0s-bot mentioned this pull request Oct 18, 2023
Merged
This was referenced Oct 19, 2023
Merged
Merged
@k0s-bot k0s-bot mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch chore documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @k0s-bot @jnummelin