Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footloose-alpine Dockerfile #2552

Merged

Conversation

juanluisvaladas
Copy link
Contributor

@juanluisvaladas juanluisvaladas commented Dec 23, 2022

Description

The footloose-alpine image broke because the cri-dockerd release ships a tar.gz. rather than an executable.

Signed-off-by: Juan Luis de Sousa-Valadas Castaño [email protected]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@juanluisvaladas juanluisvaladas requested a review from a team as a code owner December 23, 2022 12:02
The footloose-alpine image broke because the cri-dockerd release ships a
tar.gz. rather than an executable.

Signed-off-by: Juan Luis de Sousa-Valadas Castaño <[email protected]>
@twz123
Copy link
Member

twz123 commented Dec 23, 2022

Oh nice. They seem to have changed the GitHub release page to the old format. I had to adjust this when updating to the newest version.

@juanluisvaladas juanluisvaladas merged commit 0e2f84a into k0sproject:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants