Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid having multiple coredns replicas in the same node #2542

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

juanluisvaladas
Copy link
Contributor

Description

Coredns were scheduled in the same node sometimes, often causing a SPOF

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@juanluisvaladas juanluisvaladas requested a review from a team as a code owner December 20, 2022 13:01
@jnummelin
Copy link
Member

Maybe we could also add a check to say check-basic smoke that this actually behaves as expected?

@juanluisvaladas
Copy link
Contributor Author

juanluisvaladas commented Dec 20, 2022

Maybe we could also add a check to say check-basic smoke that this actually behaves as expected?

Good idea. Added now. The commit is amended but there aren't modifications outside inttest/basic/basic_test.go

Signed-off-by: Juan Luis de Sousa-Valadas Castaño <[email protected]>
beta.kubernetes.io/os deprecated since v1.14

Signed-off-by: Juan Luis de Sousa-Valadas Castaño <[email protected]>
@juanluisvaladas juanluisvaladas merged commit 70697fb into k0sproject:main Dec 23, 2022
@juanluisvaladas juanluisvaladas deleted the fix-coredns-affinity branch December 23, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants