Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable konnectivity agent control plane proxy if not used #2534

Merged

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 19, 2022

Description

The control plane proxy provided by konnectivity agent is only used if k0s is running in tunneled networking mode. The konnectivity agent starts it by default. Explicitly disable konnectivity's NodeToMasterTraffic feature gate if not using tunneled networking mode, so that the unused proxy isn't launched in that case.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

The control plane proxy provided by konnectivity agent is only used if
k0s is running in tunneled networking mode. The konnectivity agent
starts it by default. Explicitly disable konnectivity's
NodeToMasterTraffic feature gate if not using tunneled networking mode,
so that the unused proxy isn't launched in that case.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 merged commit 65debc4 into k0sproject:main Dec 20, 2022
@twz123 twz123 deleted the konnectivity-kas-tunnel-only-if-necessary branch December 20, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants