Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on systems using BSD make #55

Merged
merged 2 commits into from
Sep 13, 2015

Conversation

kazuho
Copy link
Contributor

@kazuho kazuho commented Sep 6, 2015

The line below causes build error on systems using BSD make (FreeBSD, NetBSD, etc.), since BSD make substitutes $< with an empty string if more than one file is specified as the dependency.

oniguruma.pc: $(srcdir)/oniguruma.pc.in Makefile
    $(do_subst) < $(<) > $(@)

This PR fixes the issue by hard-coding the first argument in place of $<.

note: when there are more than one dependency, GNU make uses the first argument for substituting `$<`.  OTOH BSD make substitutes the
variable with an empty string; fo example see https://gist.github.com/kazuho/0db34cb89a9a875b1743
kazuho added a commit to kazuho/mruby-onig-regexp that referenced this pull request Sep 9, 2015
k-takata added a commit that referenced this pull request Sep 13, 2015
Fix build error on systems using BSD make
@k-takata k-takata merged commit 9dc88a8 into k-takata:master Sep 13, 2015
@k-takata
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants