Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Ruby and update Unicode to 11.0 #112

Merged
merged 10 commits into from
Jan 24, 2019
Merged

Import Ruby and update Unicode to 11.0 #112

merged 10 commits into from
Jan 24, 2019

Conversation

k-takata
Copy link
Owner

Import the latest codes from Ruby.
Also update the Unicode version to 11.0.0.

regexec.c: invalidate previously matched position

* regexec.c (match_at): invalidate end position not yet matched
  when new start position is pushed, to dispose previously stored
  position.  [ruby-core:83743] [Bug #14101]
initializer paren-string `{("str")}` is a C99ism

First, `"str"` is a string constant but `("str")` is not.  It is a
random expression whose type happen to be const char*.  Second,
non-constant initializer element is forbidden in C90.  Mixture of
these two results in the fact that `{("str")}` is a C99ism.

Just delete the parens and everything goes well.
label as lvalue is a GCCism
Fix typos.

  * refered -> referred
Fix issues detected by code analysis tool (mainly Coverity).

* Fix for "top_root" leaking the resource.

[Fix GH-1956]

From: Jun Aruga <[email protected]>
regerror.c: lenghten MAX_ERROR_PAR_LEN to contain old property names
prepare for Unicode 11.0.0 update

- enc/unicode/case-folding.rb:
  - Convert unpredicted case to actual flag setting
  - Eliminate an unused variable
  - Change a variable name to avoid a warning
It seems that the changes are mainly for Unicode 11.0.0.

r65085, r65086, r65087, r65094, r65972, r66014, r66020, r66021, r66030,
r66031, r66032, r66033, r66034, r66042, r66043, r66044, r66045, r66046,
r66047, r66048, r66052, r66057, r66063, r66070, r66071, r66072, r66113,
r66114, r66115, r66116, r66122, r66123, r66132, r66135, r66137, r66138,
r66139, r66213, r66214, r66217, r66218, r66232, r66234, r66239, r66240,
r66267, r66269
It seems that the changes are mainly for Unicode 11.0.0.

r65086, r65087, r65088, r65091, r65093, r65752, r65971, r66103, r66133,
r66232, r66300
Unicode 11.0.0
Emoji 11.0
@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #112 into master will decrease coverage by 0.71%.
The diff coverage is 84.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   82.93%   82.21%   -0.72%     
==========================================
  Files          62       62              
  Lines       12795    12431     -364     
==========================================
- Hits        10611    10220     -391     
- Misses       2184     2211      +27
Impacted Files Coverage Δ
enc/unicode/name2ctype.h 100% <ø> (ø) ⬆️
regerror.c 75.3% <ø> (ø) ⬆️
enc/unicode/casefold.h 100% <ø> (ø) ⬆️
enc/unicode.c 70.06% <0%> (-1.42%) ⬇️
regexec.c 91.07% <100%> (ø) ⬆️
regcomp.c 92.18% <83.33%> (-0.04%) ⬇️
regparse.c 90.47% <92.14%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff464e9...fb47ebb. Read the comment docs.

@k-takata k-takata merged commit 8049056 into master Jan 24, 2019
@k-takata k-takata deleted the import-ruby branch January 24, 2019 10:22
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 80.082% when pulling fb47ebb on import-ruby into ff464e9 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants