Skip to content

Commit

Permalink
Only call default steps once, not once for each PathSet
Browse files Browse the repository at this point in the history
Running steps multiple times defeats the whole point of rust-lang#96501,
since lint messages will be duplicated.
  • Loading branch information
jyn514 committed Jun 26, 2022
1 parent 0e1a6fb commit ee8e0bc
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/bootstrap/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,7 @@ impl StepDescription {
if paths.is_empty() || builder.config.include_default_paths {
for (desc, should_run) in v.iter().zip(&should_runs) {
if desc.default && should_run.is_really_default() {
for pathset in &should_run.paths {
desc.maybe_run(builder, vec![pathset.clone()]);
}
desc.maybe_run(builder, should_run.paths.iter().cloned().collect());
}
}
}
Expand Down

0 comments on commit ee8e0bc

Please sign in to comment.