Support pkcs11 #704
Closed
Support pkcs11 #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After thinking more on this, I believe this is not the way to go. |
ghost
closed this
|
Just a quick comment: a lot of this logic is changing places for the next release to accommodate the #279 work. Feel free to look at that branch if you're curious. Cheers! |
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes as part of the issue described in #700.
The purpose of this PR is to only do key length validation when we are working with public keys, otherwise we just check if the provided key is a valid private key. The reason for this is the fact that when using private keys it is not guaranteed we know the key length. Also, if the key has an invalid key length, the operation will fail anyway, however in a later stage (as java cannot perform
SHA256withECDSAwith an invalid key length).