-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial JWE support #113
Comments
Any timeframe for full JWE support? Many Thanks, |
Hi Jeff! That work is being done in the jwe branch. Most of it has been done actually - the current delay is that many of the JWE test vectors are defined in the spec in JWK format, which means.... now we have to support JWK first ;) So, progress has been good, but we still need to wrap up the JWK and test support to guarantee correct/exact results. If you check out the branch and try it out, feedback is welcome! Cheers! |
Test vectors to verify the implementation are here: https://tools.ietf.org/html/rfc7520 |
The last commit in the JWE branch seems to have been about a year ago - is it still alive? |
why readme says jwk is supported if it isnt actually ? |
@vicente-valls it says "based on" - it didn't say fully implemented. If you read the README, you'd see that we explicitly indicate that JWE is not yet fully supported: https://github.com/jwtk/jjwt#currently-unsupported-features That said, most of the |
@lhazlewood tbh, I dont understand whats the meaning of |
@vicente-valls "based on" means that we use those RFCs (and only those RFCs) to build JJWT - we don't use any other sources. But it does not mean that we've fully implemented the entire specification yet. This is why we have a "currently unsupported features" section in the README to indicate that we don't yet support 100% of the features. We will eventually support them all - it just takes time. |
Does 90ade64 provide full JWE support, or is this still a work in progress? Any estimate for a release with JWE support? |
@dbadia it's still a work in progress - I'd say it's about 90% complete. Unfortunately we can't give time estimates since we're volunteers and work on it when our employment isn't consuming all of our time. :) |
@lhazlewood Understood, thanks for the quick reply |
impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces
impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted.
Amazing to see progress on this issue. ❤️ |
Is there something we can support you with? Any stories/tasks/tests you can delegate? |
impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted.
impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted.
impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted.
impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted.
impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted.
impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted.
impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted.
impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted.
- impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces - KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted. - Added JWE EncryptionAlgorithm and supporting interfaces/implementations, and refactored SignatureAlgorithm to be an interface instead of an enum to enable custom algorithms - NoneSignatureAlgorithm cleanup. Added UnsupportedKeyExceptionTest. - testing additions, cleanup cont'd
- impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces - KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted. - Added JWE EncryptionAlgorithm and supporting interfaces/implementations, and refactored SignatureAlgorithm to be an interface instead of an enum to enable custom algorithms - NoneSignatureAlgorithm cleanup. Added UnsupportedKeyExceptionTest. - testing additions, cleanup cont'd
- impl checkpoint: adjusted @SInCE version, added KeyManagementMode concept w/ supporting interfaces - KeyManagementMode interfaces and implementations are dummy implementations to enable compiling. Design still needs to be vetted. - Added JWE EncryptionAlgorithm and supporting interfaces/implementations, and refactored SignatureAlgorithm to be an interface instead of an enum to enable custom algorithms - NoneSignatureAlgorithm cleanup. Added UnsupportedKeyExceptionTest. - testing additions, cleanup cont'd
- Added JWE AeadAlgorithm and KeyAlgorithm and supporting interfaces/implementations, and refactored SignatureAlgorithm to be an interface instead of an enum to enable custom algorithms - NoneSignatureAlgorithm cleanup. Added UnsupportedKeyExceptionTest. - Added JWK support!
Shared key (
dir
) encryption first, more complicated next.The text was updated successfully, but these errors were encountered: